Enforce 90% combined coverage floor in CI #29

Merged

brian merged 4 commits from cursor/enforce-coverage-floor into main 2026-07-07 20:41:45 +02:00

Conversation 1 Commits 4 Files Changed 3

+40 -5

brian commented 2026-07-07 20:30:41 +02:00

Owner

Copy Link

Copy Source

Summary
Adds a 95% combined coverage floor enforced after unit and integration coverage are merged in CI.

pyproject.toml — adds [tool.coverage.run] and [tool.coverage.report] with fail_under = 95 (also applies to local uv run coverage report)
test.yml — splits the coverage-report job into show + enforce steps; reads fail_under from pyproject.toml so the threshold is defined in one place
README.md — documents the floor and how to check coverage locally
Combined coverage is already at 95%, so this should not require new tests.

Test plan

CI coverage-report job passes on this PR

Enforce step logs the threshold from pyproject.toml and reports "Coverage floor met."

Summary Adds a 95% combined coverage floor enforced after unit and integration coverage are merged in CI. pyproject.toml — adds [tool.coverage.run] and [tool.coverage.report] with fail_under = 95 (also applies to local uv run coverage report) test.yml — splits the coverage-report job into show + enforce steps; reads fail_under from pyproject.toml so the threshold is defined in one place README.md — documents the floor and how to check coverage locally Combined coverage is already at 95%, so this should not require new tests. Test plan CI coverage-report job passes on this PR Enforce step logs the threshold from pyproject.toml and reports "Coverage floor met."

brian added 1 commit 2026-07-07 20:30:42 +02:00

Enforce a 95% combined coverage floor in CI and local runs. ... 5393efc6cd

Configure fail_under in pyproject.toml and read it in the coverage-report workflow so the threshold stays in one place.

Co-authored-by: Cursor <cursoragent@cursor.com>

brian added 1 commit 2026-07-07 20:33:25 +02:00

Skip coverage floor check in partial CI test jobs. ... 34632980ba

Unit and integration jobs each produce partial coverage; pytest-cov reads fail_under from pyproject.toml unless overridden with --cov-fail-under=0.

Co-authored-by: Cursor <cursoragent@cursor.com>

brian added 1 commit 2026-07-07 20:34:59 +02:00

Document where combined coverage floor is enforced in CI. ... 5c8cd841b6

Clarify that unit and integration jobs skip the floor check because they only produce partial coverage.

Co-authored-by: Cursor <cursoragent@cursor.com>

brian added 1 commit 2026-07-07 20:39:12 +02:00

Lower combined coverage floor from 95% to 90%. ... a381d45650

Update fail_under in pyproject.toml and the README to match.

Co-authored-by: Cursor <cursoragent@cursor.com>

ci-bot commented 2026-07-07 20:40:22 +02:00

Member

Copy Link

Copy Source

Test Coverage Report:

Name                                                            Stmts   Miss   Cover   Missing
----------------------------------------------------------------------------------------------
python_repositories/__init__.py                                    12      1  91.67%   43
python_repositories/adapters/__init__.py                           13      2  84.62%   37, 42
python_repositories/adapters/connection_aware_adapter.py           45      0 100.00%
python_repositories/adapters/minio_adapter.py                     119      8  93.28%   62-70, 75
python_repositories/adapters/redis_adapter.py                      96     11  88.54%   54-65, 67-69
python_repositories/config/__init__.py                              4      0 100.00%
python_repositories/config/dotenv_loader.py                         7      0 100.00%
python_repositories/config/minio_config.py                         31      0 100.00%
python_repositories/config/redis_config.py                         14      0 100.00%
python_repositories/examples/__init__.py                            0      0 100.00%
python_repositories/examples/artifact_object_repository.py          9      0 100.00%
python_repositories/examples/user_json_repository.py               10      0 100.00%
python_repositories/interfaces/__init__.py                          5      0 100.00%
python_repositories/interfaces/connection_aware_interface.py        8      0 100.00%
python_repositories/interfaces/context_aware_interface.py           8      0 100.00%
python_repositories/interfaces/json_repository_interface.py        10      0 100.00%
python_repositories/interfaces/object_repository_interface.py      11      0 100.00%
----------------------------------------------------------------------------------------------
TOTAL                                                             402     22  94.53%

**Test Coverage Report:** ``` Name Stmts Miss Cover Missing ---------------------------------------------------------------------------------------------- python_repositories/__init__.py 12 1 91.67% 43 python_repositories/adapters/__init__.py 13 2 84.62% 37, 42 python_repositories/adapters/connection_aware_adapter.py 45 0 100.00% python_repositories/adapters/minio_adapter.py 119 8 93.28% 62-70, 75 python_repositories/adapters/redis_adapter.py 96 11 88.54% 54-65, 67-69 python_repositories/config/__init__.py 4 0 100.00% python_repositories/config/dotenv_loader.py 7 0 100.00% python_repositories/config/minio_config.py 31 0 100.00% python_repositories/config/redis_config.py 14 0 100.00% python_repositories/examples/__init__.py 0 0 100.00% python_repositories/examples/artifact_object_repository.py 9 0 100.00% python_repositories/examples/user_json_repository.py 10 0 100.00% python_repositories/interfaces/__init__.py 5 0 100.00% python_repositories/interfaces/connection_aware_interface.py 8 0 100.00% python_repositories/interfaces/context_aware_interface.py 8 0 100.00% python_repositories/interfaces/json_repository_interface.py 10 0 100.00% python_repositories/interfaces/object_repository_interface.py 11 0 100.00% ---------------------------------------------------------------------------------------------- TOTAL 402 22 94.53% ```

brian changed title from Enforce 95% combined coverage floor in CI to Enforce 90% combined coverage floor in CI 2026-07-07 20:41:35 +02:00

brian merged commit ce062be411 into main 2026-07-07 20:41:45 +02:00

brian deleted branch cursor/enforce-coverage-floor 2026-07-07 20:41:46 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

brian (Brian Bjarke Jensen) ci-bot

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lille-vemmelund/python-repositories#29