lille-vemmelund/python-repositories
2
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Releases 17 Activity

[patch] Fix MinIO get_object response leak in MinioAdapter.get() #32

Merged
brian merged 2 commits from fix/minio-get-object-response-cleanup into main 2026-07-07 21:37:06 +02:00
Conversation 2 Commits 2 Files Changed 4
+61 -1
brian commented 2026-07-07 21:24:16 +02:00
Owner
Copy Link
Copy Source

Summary
Close and release the HTTP response returned by get_object() in MinioAdapter.get(), following the MinIO Python SDK guidance (response.close() + response.release_conn() in a finally block).
Prevents connection pool exhaustion when get() is called repeatedly under load.
Add unit tests covering successful reads and mid-read failures to ensure cleanup always runs.
Test plan

uv run pytest tests/unit/minio_adapter_test.py -q

uv run pytest tests/integration/minio_adapter_test.py -m integration -q

Combined coverage remains at 100%

Summary Close and release the HTTP response returned by get_object() in MinioAdapter.get(), following the MinIO Python SDK guidance (response.close() + response.release_conn() in a finally block). Prevents connection pool exhaustion when get() is called repeatedly under load. Add unit tests covering successful reads and mid-read failures to ensure cleanup always runs. Test plan uv run pytest tests/unit/minio_adapter_test.py -q uv run pytest tests/integration/minio_adapter_test.py -m integration -q Combined coverage remains at 100%
brian added 1 commit 2026-07-07 21:24:17 +02:00
Fix MinIO get_object response leak in MinioAdapter.get().
Test Python Package / integration-tests (pull_request) Successful in 27s
Details
Code Quality Pipeline / code-quality (pull_request) Successful in 31s
Details
Test Python Package / unit-tests (pull_request) Successful in 36s
Details
Test Python Package / coverage-report (pull_request) Successful in 53s
Details
PR Title Check / check-title (pull_request) Failing after 5s
Details
8c34534187 
Close and release the HTTP response in a finally block per SDK guidance, and add unit tests for success and read-failure cleanup.

Co-authored-by: Cursor <cursoragent@cursor.com>
ci-bot commented 2026-07-07 21:25:47 +02:00
Member
Copy Link
Copy Source

Test Coverage Report:

Name                                                            Stmts   Miss    Cover   Missing
-----------------------------------------------------------------------------------------------
python_repositories/__init__.py                                    12      0  100.00%
python_repositories/adapters/__init__.py                           13      0  100.00%
python_repositories/adapters/connection_aware_adapter.py           45      0  100.00%
python_repositories/adapters/minio_adapter.py                     123      0  100.00%
python_repositories/adapters/redis_adapter.py                      96      0  100.00%
python_repositories/config/__init__.py                              4      0  100.00%
python_repositories/config/dotenv_loader.py                         7      0  100.00%
python_repositories/config/minio_config.py                         31      0  100.00%
python_repositories/config/redis_config.py                         14      0  100.00%
python_repositories/examples/__init__.py                            0      0  100.00%
python_repositories/examples/artifact_object_repository.py          9      0  100.00%
python_repositories/examples/user_json_repository.py               10      0  100.00%
python_repositories/interfaces/__init__.py                          5      0  100.00%
python_repositories/interfaces/connection_aware_interface.py        8      0  100.00%
python_repositories/interfaces/context_aware_interface.py           8      0  100.00%
python_repositories/interfaces/json_repository_interface.py        10      0  100.00%
python_repositories/interfaces/object_repository_interface.py      11      0  100.00%
-----------------------------------------------------------------------------------------------
TOTAL                                                             406      0  100.00%
**Test Coverage Report:** ``` Name Stmts Miss Cover Missing ----------------------------------------------------------------------------------------------- python_repositories/__init__.py 12 0 100.00% python_repositories/adapters/__init__.py 13 0 100.00% python_repositories/adapters/connection_aware_adapter.py 45 0 100.00% python_repositories/adapters/minio_adapter.py 123 0 100.00% python_repositories/adapters/redis_adapter.py 96 0 100.00% python_repositories/config/__init__.py 4 0 100.00% python_repositories/config/dotenv_loader.py 7 0 100.00% python_repositories/config/minio_config.py 31 0 100.00% python_repositories/config/redis_config.py 14 0 100.00% python_repositories/examples/__init__.py 0 0 100.00% python_repositories/examples/artifact_object_repository.py 9 0 100.00% python_repositories/examples/user_json_repository.py 10 0 100.00% python_repositories/interfaces/__init__.py 5 0 100.00% python_repositories/interfaces/connection_aware_interface.py 8 0 100.00% python_repositories/interfaces/context_aware_interface.py 8 0 100.00% python_repositories/interfaces/json_repository_interface.py 10 0 100.00% python_repositories/interfaces/object_repository_interface.py 11 0 100.00% ----------------------------------------------------------------------------------------------- TOTAL 406 0 100.00% ```
brian changed title from Fix MinIO get_object response leak in MinioAdapter.get() to [patch] Fix MinIO get_object response leak in MinioAdapter.get() 2026-07-07 21:27:22 +02:00
brian added 1 commit 2026-07-07 21:34:23 +02:00
Fetch live PR title in pr-title-check CI workflow.
Code Quality Pipeline / code-quality (pull_request) Successful in 24s
Details
Test Python Package / integration-tests (pull_request) Successful in 1m18s
Details
Test Python Package / unit-tests (pull_request) Successful in 1m24s
Details
Test Python Package / coverage-report (pull_request) Successful in 12s
Details
PR Title Check / check-title (pull_request) Successful in 6s
Details
9a800bf553 
Rerunning the job now reads the current title from the Gitea API instead of the stale pull_request event payload.

Co-authored-by: Cursor <cursoragent@cursor.com>
ci-bot commented 2026-07-07 21:36:02 +02:00
Member
Copy Link
Copy Source

Test Coverage Report:

Name                                                            Stmts   Miss    Cover   Missing
-----------------------------------------------------------------------------------------------
python_repositories/__init__.py                                    12      0  100.00%
python_repositories/adapters/__init__.py                           13      0  100.00%
python_repositories/adapters/connection_aware_adapter.py           45      0  100.00%
python_repositories/adapters/minio_adapter.py                     123      0  100.00%
python_repositories/adapters/redis_adapter.py                      96      0  100.00%
python_repositories/config/__init__.py                              4      0  100.00%
python_repositories/config/dotenv_loader.py                         7      0  100.00%
python_repositories/config/minio_config.py                         31      0  100.00%
python_repositories/config/redis_config.py                         14      0  100.00%
python_repositories/examples/__init__.py                            0      0  100.00%
python_repositories/examples/artifact_object_repository.py          9      0  100.00%
python_repositories/examples/user_json_repository.py               10      0  100.00%
python_repositories/interfaces/__init__.py                          5      0  100.00%
python_repositories/interfaces/connection_aware_interface.py        8      0  100.00%
python_repositories/interfaces/context_aware_interface.py           8      0  100.00%
python_repositories/interfaces/json_repository_interface.py        10      0  100.00%
python_repositories/interfaces/object_repository_interface.py      11      0  100.00%
-----------------------------------------------------------------------------------------------
TOTAL                                                             406      0  100.00%
**Test Coverage Report:** ``` Name Stmts Miss Cover Missing ----------------------------------------------------------------------------------------------- python_repositories/__init__.py 12 0 100.00% python_repositories/adapters/__init__.py 13 0 100.00% python_repositories/adapters/connection_aware_adapter.py 45 0 100.00% python_repositories/adapters/minio_adapter.py 123 0 100.00% python_repositories/adapters/redis_adapter.py 96 0 100.00% python_repositories/config/__init__.py 4 0 100.00% python_repositories/config/dotenv_loader.py 7 0 100.00% python_repositories/config/minio_config.py 31 0 100.00% python_repositories/config/redis_config.py 14 0 100.00% python_repositories/examples/__init__.py 0 0 100.00% python_repositories/examples/artifact_object_repository.py 9 0 100.00% python_repositories/examples/user_json_repository.py 10 0 100.00% python_repositories/interfaces/__init__.py 5 0 100.00% python_repositories/interfaces/connection_aware_interface.py 8 0 100.00% python_repositories/interfaces/context_aware_interface.py 8 0 100.00% python_repositories/interfaces/json_repository_interface.py 10 0 100.00% python_repositories/interfaces/object_repository_interface.py 11 0 100.00% ----------------------------------------------------------------------------------------------- TOTAL 406 0 100.00% ```
brian merged commit 8e47ebf4c6 into main 2026-07-07 21:37:06 +02:00
brian deleted branch fix/minio-get-object-response-cleanup 2026-07-07 21:37:06 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
brian (Brian Bjarke Jensen) ci-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lille-vemmelund/python-repositories#32