lille-vemmelund/python-repositories
2
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Releases 17 Activity

[patch] Use structured fields for adapter debug and info logs #46

Merged
brian merged 2 commits from cursor/structured-adapter-logging into main 2026-07-10 14:06:25 +02:00
Conversation 2 Commits 2 Files Changed 5
+27 -18
brian commented 2026-07-10 14:01:59 +02:00
Owner
Copy Link
Copy Source

Summary

Replace f-string adapter log messages with structlog keyword fields across ConnectionAwareAdapter, RedisAdapter, and MinioAdapter.

  • Use static event messages with structured context fields (for example connection_name, key, bucket, object_name)
  • Log Redis metadata instead of full payloads (data_keys, found, count) to improve aggregation and avoid logging large values verbatim
  • Update integration test assertions to match the new structured log output

Test plan

  • uv run pytest tests/integration/redis_adapter_test.py tests/integration/minio_adapter_test.py -k "log"
  • uv run pytest tests/integration/minio_adapter_test.py::test_connect_creates_bucket_when_create_bucket_if_missing_enabled
## Summary Replace f-string adapter log messages with structlog keyword fields across `ConnectionAwareAdapter`, `RedisAdapter`, and `MinioAdapter`. - Use static event messages with structured context fields (for example `connection_name`, `key`, `bucket`, `object_name`) - Log Redis metadata instead of full payloads (`data_keys`, `found`, `count`) to improve aggregation and avoid logging large values verbatim - Update integration test assertions to match the new structured log output ## Test plan - [x] `uv run pytest tests/integration/redis_adapter_test.py tests/integration/minio_adapter_test.py -k "log"` - [x] `uv run pytest tests/integration/minio_adapter_test.py::test_connect_creates_bucket_when_create_bucket_if_missing_enabled`
brian added 1 commit 2026-07-10 14:02:01 +02:00
Use structured fields for adapter debug and info logs.
PR Title Check / check-title (pull_request) Successful in 6s
Details
Test Python Package / unit-tests (pull_request) Successful in 9s
Details
Code Quality Pipeline / code-quality (pull_request) Failing after 14s
Details
Test Python Package / integration-tests (pull_request) Successful in 1m2s
Details
Test Python Package / coverage-report (pull_request) Successful in 11s
Details
b886a7c147 
Replace f-string log messages with structlog keyword fields so events aggregate cleanly and Redis payloads are not logged verbatim.

Co-authored-by: Cursor <cursoragent@cursor.com>
ci-bot commented 2026-07-10 14:03:18 +02:00
Member
Copy Link
Copy Source

Test Coverage Report:

Name                                                            Stmts   Miss    Cover   Missing
-----------------------------------------------------------------------------------------------
python_repositories/__init__.py                                    12      0  100.00%
python_repositories/adapters/__init__.py                           13      0  100.00%
python_repositories/adapters/connection_aware_adapter.py           61      0  100.00%
python_repositories/adapters/minio_adapter.py                     117      0  100.00%
python_repositories/adapters/redis_adapter.py                     105      0  100.00%
python_repositories/config/__init__.py                              4      0  100.00%
python_repositories/config/dotenv_loader.py                         7      0  100.00%
python_repositories/config/env_bool.py                             14      0  100.00%
python_repositories/config/minio_config.py                         21      0  100.00%
python_repositories/config/redis_config.py                         14      0  100.00%
python_repositories/examples/__init__.py                            0      0  100.00%
python_repositories/examples/artifact_object_repository.py          9      0  100.00%
python_repositories/examples/user_json_repository.py               11      0  100.00%
python_repositories/interfaces/__init__.py                          5      0  100.00%
python_repositories/interfaces/connection_aware_interface.py        8      0  100.00%
python_repositories/interfaces/context_aware_interface.py           8      0  100.00%
python_repositories/interfaces/json_repository_interface.py        15      0  100.00%
python_repositories/interfaces/object_repository_interface.py      11      0  100.00%
-----------------------------------------------------------------------------------------------
TOTAL                                                             435      0  100.00%
**Test Coverage Report:** ``` Name Stmts Miss Cover Missing ----------------------------------------------------------------------------------------------- python_repositories/__init__.py 12 0 100.00% python_repositories/adapters/__init__.py 13 0 100.00% python_repositories/adapters/connection_aware_adapter.py 61 0 100.00% python_repositories/adapters/minio_adapter.py 117 0 100.00% python_repositories/adapters/redis_adapter.py 105 0 100.00% python_repositories/config/__init__.py 4 0 100.00% python_repositories/config/dotenv_loader.py 7 0 100.00% python_repositories/config/env_bool.py 14 0 100.00% python_repositories/config/minio_config.py 21 0 100.00% python_repositories/config/redis_config.py 14 0 100.00% python_repositories/examples/__init__.py 0 0 100.00% python_repositories/examples/artifact_object_repository.py 9 0 100.00% python_repositories/examples/user_json_repository.py 11 0 100.00% python_repositories/interfaces/__init__.py 5 0 100.00% python_repositories/interfaces/connection_aware_interface.py 8 0 100.00% python_repositories/interfaces/context_aware_interface.py 8 0 100.00% python_repositories/interfaces/json_repository_interface.py 15 0 100.00% python_repositories/interfaces/object_repository_interface.py 11 0 100.00% ----------------------------------------------------------------------------------------------- TOTAL 435 0 100.00% ```
brian added 1 commit 2026-07-10 14:04:41 +02:00
Fix mypy error in Minio adapter log assertion.
Test Python Package / unit-tests (pull_request) Successful in 10s
Details
Code Quality Pipeline / code-quality (pull_request) Successful in 33s
Details
Test Python Package / integration-tests (pull_request) Successful in 20s
Details
PR Title Check / check-title (pull_request) Successful in 42s
Details
Test Python Package / coverage-report (pull_request) Successful in 14s
Details
82a702db0c 
Narrow optional bucket name before checking it appears in captured log text.

Co-authored-by: Cursor <cursoragent@cursor.com>
ci-bot commented 2026-07-10 14:05:39 +02:00
Member
Copy Link
Copy Source

Test Coverage Report:

Name                                                            Stmts   Miss    Cover   Missing
-----------------------------------------------------------------------------------------------
python_repositories/__init__.py                                    12      0  100.00%
python_repositories/adapters/__init__.py                           13      0  100.00%
python_repositories/adapters/connection_aware_adapter.py           61      0  100.00%
python_repositories/adapters/minio_adapter.py                     117      0  100.00%
python_repositories/adapters/redis_adapter.py                     105      0  100.00%
python_repositories/config/__init__.py                              4      0  100.00%
python_repositories/config/dotenv_loader.py                         7      0  100.00%
python_repositories/config/env_bool.py                             14      0  100.00%
python_repositories/config/minio_config.py                         21      0  100.00%
python_repositories/config/redis_config.py                         14      0  100.00%
python_repositories/examples/__init__.py                            0      0  100.00%
python_repositories/examples/artifact_object_repository.py          9      0  100.00%
python_repositories/examples/user_json_repository.py               11      0  100.00%
python_repositories/interfaces/__init__.py                          5      0  100.00%
python_repositories/interfaces/connection_aware_interface.py        8      0  100.00%
python_repositories/interfaces/context_aware_interface.py           8      0  100.00%
python_repositories/interfaces/json_repository_interface.py        15      0  100.00%
python_repositories/interfaces/object_repository_interface.py      11      0  100.00%
-----------------------------------------------------------------------------------------------
TOTAL                                                             435      0  100.00%
**Test Coverage Report:** ``` Name Stmts Miss Cover Missing ----------------------------------------------------------------------------------------------- python_repositories/__init__.py 12 0 100.00% python_repositories/adapters/__init__.py 13 0 100.00% python_repositories/adapters/connection_aware_adapter.py 61 0 100.00% python_repositories/adapters/minio_adapter.py 117 0 100.00% python_repositories/adapters/redis_adapter.py 105 0 100.00% python_repositories/config/__init__.py 4 0 100.00% python_repositories/config/dotenv_loader.py 7 0 100.00% python_repositories/config/env_bool.py 14 0 100.00% python_repositories/config/minio_config.py 21 0 100.00% python_repositories/config/redis_config.py 14 0 100.00% python_repositories/examples/__init__.py 0 0 100.00% python_repositories/examples/artifact_object_repository.py 9 0 100.00% python_repositories/examples/user_json_repository.py 11 0 100.00% python_repositories/interfaces/__init__.py 5 0 100.00% python_repositories/interfaces/connection_aware_interface.py 8 0 100.00% python_repositories/interfaces/context_aware_interface.py 8 0 100.00% python_repositories/interfaces/json_repository_interface.py 15 0 100.00% python_repositories/interfaces/object_repository_interface.py 11 0 100.00% ----------------------------------------------------------------------------------------------- TOTAL 435 0 100.00% ```
brian merged commit 0a39151ba0 into main 2026-07-10 14:06:25 +02:00
brian deleted branch cursor/structured-adapter-logging 2026-07-10 14:06:26 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
brian (Brian Bjarke Jensen) ci-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lille-vemmelund/python-repositories#46