lille-vemmelund/python-repositories
2
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Releases 17 Activity

Drop types-redis in favor of redis inline types #51

Merged
brian merged 1 commits from cursor/drop-types-redis into main 2026-07-10 19:28:22 +02:00
Conversation 1 Commits 1 Files Changed 2
+1 -51
brian commented 2026-07-10 19:26:08 +02:00
Owner
Copy Link
Copy Source

Summary

Remove types-redis from dev dependencies. The stubs target redis 4.6, while the project uses redis>=6.4.0 (currently 8.x) with built-in py.typed annotations.

Keeping both installed caused mypy to prefer outdated external stubs over redis-py's inline types, which are more accurate for the JSON APIs used in RedisAdapter (json().set/get/delete, RedisPath, etc.).

No runtime or application code changes. Mypy continues to rely on redis types via the existing uv sync --all-extras workflow.

Test plan

  • uv run mypy .
  • uv run ruff check .
  • uv run pytest tests/unit/ -m "not integration"
## Summary Remove `types-redis` from dev dependencies. The stubs target redis 4.6, while the project uses `redis>=6.4.0` (currently 8.x) with built-in `py.typed` annotations. Keeping both installed caused mypy to prefer outdated external stubs over redis-py's inline types, which are more accurate for the JSON APIs used in `RedisAdapter` (`json().set/get/delete`, `RedisPath`, etc.). No runtime or application code changes. Mypy continues to rely on redis types via the existing `uv sync --all-extras` workflow. ## Test plan - [x] `uv run mypy .` - [x] `uv run ruff check .` - [x] `uv run pytest tests/unit/ -m "not integration"`
brian added 1 commit 2026-07-10 19:26:10 +02:00
Drop types-redis in favor of redis inline types.
PR Title Check / check-title (pull_request) Successful in 7s
Details
Test Python Package / unit-tests (pull_request) Successful in 12s
Details
Test Python Package / integration-tests (pull_request) Successful in 25s
Details
Test Python Package / coverage-report (pull_request) Successful in 11s
Details
Code Quality Pipeline / code-quality (pull_request) Successful in 47s
Details
10d43ce198 
The outdated redis 4.6 stubs conflicted with redis 6+ py.typed annotations used at runtime.

Co-authored-by: Cursor <cursoragent@cursor.com>
ci-bot commented 2026-07-10 19:26:51 +02:00
Member
Copy Link
Copy Source

Test Coverage Report:

Name                                                            Stmts   Miss    Cover   Missing
-----------------------------------------------------------------------------------------------
python_repositories/__init__.py                                    12      0  100.00%
python_repositories/adapters/__init__.py                           13      0  100.00%
python_repositories/adapters/connection_aware_adapter.py           61      0  100.00%
python_repositories/adapters/minio_adapter.py                     117      0  100.00%
python_repositories/adapters/redis_adapter.py                     105      0  100.00%
python_repositories/config/__init__.py                              4      0  100.00%
python_repositories/config/dotenv_loader.py                         7      0  100.00%
python_repositories/config/env_bool.py                             14      0  100.00%
python_repositories/config/minio_config.py                         21      0  100.00%
python_repositories/config/redis_config.py                         14      0  100.00%
python_repositories/examples/__init__.py                            0      0  100.00%
python_repositories/examples/artifact_object_repository.py          9      0  100.00%
python_repositories/examples/user_json_repository.py               11      0  100.00%
python_repositories/interfaces/__init__.py                          5      0  100.00%
python_repositories/interfaces/connection_aware_interface.py        8      0  100.00%
python_repositories/interfaces/context_aware_interface.py           8      0  100.00%
python_repositories/interfaces/json_repository_interface.py        15      0  100.00%
python_repositories/interfaces/object_repository_interface.py      11      0  100.00%
-----------------------------------------------------------------------------------------------
TOTAL                                                             435      0  100.00%
**Test Coverage Report:** ``` Name Stmts Miss Cover Missing ----------------------------------------------------------------------------------------------- python_repositories/__init__.py 12 0 100.00% python_repositories/adapters/__init__.py 13 0 100.00% python_repositories/adapters/connection_aware_adapter.py 61 0 100.00% python_repositories/adapters/minio_adapter.py 117 0 100.00% python_repositories/adapters/redis_adapter.py 105 0 100.00% python_repositories/config/__init__.py 4 0 100.00% python_repositories/config/dotenv_loader.py 7 0 100.00% python_repositories/config/env_bool.py 14 0 100.00% python_repositories/config/minio_config.py 21 0 100.00% python_repositories/config/redis_config.py 14 0 100.00% python_repositories/examples/__init__.py 0 0 100.00% python_repositories/examples/artifact_object_repository.py 9 0 100.00% python_repositories/examples/user_json_repository.py 11 0 100.00% python_repositories/interfaces/__init__.py 5 0 100.00% python_repositories/interfaces/connection_aware_interface.py 8 0 100.00% python_repositories/interfaces/context_aware_interface.py 8 0 100.00% python_repositories/interfaces/json_repository_interface.py 15 0 100.00% python_repositories/interfaces/object_repository_interface.py 11 0 100.00% ----------------------------------------------------------------------------------------------- TOTAL 435 0 100.00% ```
brian merged commit 4f6f33f36e into main 2026-07-10 19:28:22 +02:00
brian deleted branch cursor/drop-types-redis 2026-07-10 19:28:22 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
brian (Brian Bjarke Jensen) ci-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lille-vemmelund/python-repositories#51